![]() With one change to update class name on line 26 of ProjectUnitTest.php, DrupalPractice all would you be interested in a pull request or patch of some sort? But it's probably best to defer that work until after we can just get to 3.0. If we go to phpcs v3.2.1, Drupal fails unit tests for ArrayUnitTest, FileCommentUnitTest, and GoodUnitTest. I had to do the same with ClassFilesSniff in DrupalPractice\Project.php. It's not a perfect solution, but it works. One thing I did notice is that when phpcs runs a standard now, it does not seem to find classes in other namespaces - so to get DrupalPractice to run, I had to copy FunctionCall and FunctionDefinition from Semantics in Drupal to a new semantic directory in DrupalPractice and modify several use statements to update the use statement. ![]() I pulled a copy of to try to understand where this effort is and if I might be able to help. Users/pwaters/coder/coder_sniffer/Drupal/Test/CoderSniffUnitTest.php:41Ģ) Drupal\Sniffs\Arrays\DisallowLongArraySyntaxUnitTest::testSniffģ) Drupal\Sniffs\Classes\ClassCreateInstanceUnitTest::testSniffĤ) Drupal\Sniffs\Classes\ClassDeclarationUnitTest::testSniff PHPUnit 5.7.20 by Sebastian Bergmann and contributors.ĮEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE 65 / 76 ( 85%)ġ) Drupal\Sniffs\Arrays\ArrayUnitTest::testSniffĮrror: Class 'PHP_CodeSniffer\Config' not found I got around the first error but now it looks like things changed a ton in, almost every single test failed Any chance you can just lift the composer requirement and it will just work? I need to use phpcs 3.0.0 because a new feature "Basepath option to show relative path names in report output" is added in 3.0.0 but not available in 2.x(details in ).Īs I'm running phpcs with Vagrant / Docker and Jenkins, this basepath feature is pretty important to me. I'm not sure if Coder really cannot support phpcs 3.0.0? Is there any blockers? drupal/coder 8.2.10 requires squizlabs/php_codesniffer >=2.7.0 satisfiable by squizlabs/php_codesniffer but these conflict with your requirements or minimum-stability. Your requirements could not be resolved to an installable set of packages. Updating dependencies (including require-dev) Loading composer repositories with package information ![]() Composer global require squizlabs/php_codesniffer:3.0.0RC4
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |